Skip to content

Remove calculate_images_to_build function #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Remove calculate_images_to_build function #131

wants to merge 5 commits into from

Conversation

SimonBaeumer
Copy link
Contributor

@SimonBaeumer SimonBaeumer commented May 15, 2025 •
edited
Loading

Summary

Removing calculate_images_to_build function. This function was never used in the intended implementation. exclude was never used for pipeline.py in CI & scirpts, only include was used.
--include was only ever called once, it never used action=append. To simplify the implementation just the key of the image to build is returned.

Proof of Work

  • CI Pipline
  • rg search locally and check usages for --exclude and --include
❯ rg pipeline.py
lib/sonar/builders/docker.py
195:    # - move the logic out of sonar to pipeline.py to all the places where we build context images

inventories/daily.yaml
2:  # these variables are configured from the outside, in pipeline.py::image_config

scripts/dev/contexts/evg-private-context
98:# var used in pipeline.py to determine if we're running on EVG host

Makefile
72:	@ scripts/evergreen/run_python.sh pipeline.py --include database
75:	@ scripts/evergreen/run_python.sh pipeline.py --include readiness-probe
78:	@ scripts/evergreen/run_python.sh pipeline.py --include upgrade-hook
87:	@ scripts/evergreen/run_python.sh pipeline.py --include appdb
151:	@ scripts/evergreen/run_python.sh pipeline.py --include operator-quick
158:		scripts/evergreen/run_python.sh pipeline.py --include test; \
163:		scripts/evergreen/run_python.sh pipeline.py --include mco-test; \
178:	@ scripts/evergreen/run_python.sh pipeline.py --include init-database
181:	@ scripts/evergreen/run_python.sh pipeline.py --include init-appdb
186:	@ scripts/evergreen/run_python.sh pipeline.py --include agent --all-agents --parallel --parallel-factor 6
189:	@ scripts/evergreen/run_python.sh pipeline.py --include agent --parallel-factor 1
192:	@ scripts/evergreen/run_python.sh pipeline.py --include operator
195:	@ scripts/evergreen/run_python.sh pipeline.py --include init-ops-manager
198:	@ scripts/evergreen/run_python.sh pipeline.py --include ops-manager

scripts/dev/contexts/local-defaults-context
58:# TO ensure we don't release by accident via pipeline.py

docker/mongodb-agent/Dockerfile.builder
1:# the init database image gets supplied by pipeline.py and corresponds to the operator version we want to release

@SimonBaeumer SimonBaeumer requested a review from a team as a code owner May 15, 2025 15:55
@SimonBaeumer SimonBaeumer requested review from MaciejKaras and mircea-cosbuc and removed request for a team May 15, 2025 15:55
@SimonBaeumer SimonBaeumer changed the title Remove calculate_images_to_build function WIP: Remove calculate_images_to_build function May 15, 2025
MaciejKaras
MaciejKaras reviewed May 16, 2025
View reviewed changes
@SimonBaeumer SimonBaeumer force-pushed the simon/add-calc-images-test-cases branch 2 times, most recently from 8c1cb60 to b333772 Compare May 16, 2025 09:34
@SimonBaeumer SimonBaeumer marked this pull request as draft May 26, 2025 07:31
@SimonBaeumer SimonBaeumer force-pushed the simon/remove-unused-params branch from e69f976 to 3753163 Compare June 13, 2025 12:37
@SimonBaeumer SimonBaeumer changed the base branch from simon/add-calc-images-test-cases to master June 13, 2025 12:38
@SimonBaeumer SimonBaeumer marked this pull request as ready for review June 13, 2025 12:39
@SimonBaeumer SimonBaeumer changed the title WIP: Remove calculate_images_to_build function Remove calculate_images_to_build function Jun 13, 2025
@SimonBaeumer SimonBaeumer requested a review from MaciejKaras June 13, 2025 12:42
Julien-Ben
Julien-Ben requested changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@Julien-Ben Julien-Ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the PR has been approved but all images builds are failing in CI
I'll block it to make sure we don't merge accidentally

mircea-cosbuc
mircea-cosbuc requested changes Jul 10, 2025
View reviewed changes
Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be superseded by the work on Atomic releases. Should we close it instead? @MaciejKaras @Julien-Ben

@MaciejKaras
Copy link
Collaborator

@mircea-cosbuc It will be superseded by Atomic Releases, but until then I don't mind merging it (it only removes code smell). On the other hand if it requires effort to fix the broken tests I would probably abandon it.

@Julien-Ben
Copy link
Collaborator

Since there are build failures and this is being tackled as part of our Epic, I think we should close it @mircea-cosbuc

@MaciejKaras
Copy link
Collaborator

Let's close the PR as we are already using atomic_pipeline.py for most of the images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mircea-cosbuc mircea-cosbuc mircea-cosbuc requested changes

@Julien-Ben Julien-Ben Julien-Ben requested changes

@MaciejKaras MaciejKaras MaciejKaras approved these changes

@nammn nammn nammn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonBaeumer @MaciejKaras @Julien-Ben @mircea-cosbuc @nammn